[build] Remove hsimple tutorial from main CMake build #15930
Conversation
The main motivation is because it is a clear blocker for proper cross-compilation. Also, the tutorial itself is already run as the first tutorial irrespective of the build configuration so the test is actually repeated.
Test Results 13 files 13 suites 2d 15h 37m 31s ⏱️ For more details on these failures, see this check. Results for commit 4fa46b1. ♻️ This comment has been updated with latest results. |
The file is created anew with compression setting 209 (LZMA level 9) in order to minimise the size footprint on the repository (384Kb). This way tutorials that require the presence of the file can just take it from the local directory without the need for dependency on another tutorial.
|
cross-compilation is blocked by the creation of |
|
It's still one less patch needed for the conda packaging. Clearly there's a bigger rock to move, but this smaller one could be moved anyway perhaps? |
|
But how do you solve the |
The build is actually cross-compiling as requested in the This does not explain alone the fact that there is also a patch to disable IMHO clearly the better approach is to have less patches and walk towards a fully cross-compilable ROOT build, albeit this PR might be just a very small step. |
Sure, so can we just remove the patch from the conda forge and see what happens? It's still not clear to me why it is needed.
I agree, but I don't see the bigger picture here: how do you want to achieve this with all of |
|
I agree we should wait for a more robust solution for cross-compilation of the whole project before removing this simple test. I will close this PR and if in the future we decide what to do we can resume from here 👍 |
The main motivation is because it is a clear blocker for proper cross-compilation. Also, the tutorial itself is already run as the first tutorial irrespective of the build configuration so the test is actually repeated.