Hopefully, fix the long-standing problem with h2root #15915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 13 files 13 suites 2d 23h 41m 39s ⏱️ Results for commit 4f15d91. ♻️ This comment has been updated with latest results. |
|
As far as I can tell, this shouldn't make a difference because root/misc/minicern/src/hbook.f Lines 260 to 263 in 80023e0 |
1 task
|
@hahnjo it made on on MacOS. (long debug) |
| @@ -373,6 +373,7 @@ SUBROUTINE HRFILE(LUN,CHDIR,CHOPT) | |||
| ENDIF | |||
| 10 CHMAIL='//'//CHTOP(NCHTOP) | |||
| CALL HCDIR(CHMAIL,' ') | |||
|
|
|||
|
my comment from #15915 (comment) still stands: based on the code, there should be no change in behavior because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the C option (meaning C I.O) in hropen seems to fix the issue on Mac.