[RF][CMake] Some fixes to RooFit CMake files #15664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The targets are using the headers in `res` themselves when compiling: it's not only an interface dependency when compiling against the target. It worked before, but like this it's more precise and the configuration is more robust. Will help in particular when building RooFit standalone.
Add some missing dependencies for test executables.
Test Results 12 files 12 suites 2d 16h 57m 18s ⏱️ Results for commit 8f75740. |
bellenot
approved these changes
May 29, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
1 similar comment
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
pcanal
reviewed
May 31, 2024
| @@ -16,7 +16,7 @@ if(cuda) | |||
| target_compile_definitions(RooBatchCompute PUBLIC ROOFIT_CUDA) | |||
| endif() | |||
|
|
|||
| target_include_directories(RooBatchCompute INTERFACE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/res>) | |||
| target_include_directories(RooBatchCompute PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/res>) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit descriptions.
Should be also backported to 6.32.
Some of the changes are also part of #8709.