[cxxmodules] Do not use FindObject when we have the Decl*. #1416

vgvassilev · 2017-12-04T10:20:30Z

No description provided.

vgvassilev · 2017-12-04T12:39:40Z

phsft-bot · 2017-12-04T12:43:50Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-12-04T12:48:11Z

Build failed on mac1012/native.
See console output.

Errors:

/Volumes/MacintoshHD/build/jenkins/workspace/root-pullrequests-build/root/core/metacling/src/TCling.cxx:558:16: error: cannot initialize a variable of type 'clang::VarDecl *' with an rvalue of type 'const clang::VarDecl *'
/Volumes/MacintoshHD/build/jenkins/workspace/root-pullrequests-build/root/core/metacling/src/TCling.cxx:560:38: error: no member named 'Find' in 'TCollection'

phsft-bot · 2017-12-04T13:29:41Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-12-04T13:58:31Z

Build failed on centos7/gcc49.
See console output.

Failing tests:

projectroot.roottest.root.meta.roottest_root_meta_execUnloading_auto

phsft-bot · 2017-12-04T13:59:39Z

Build failed on slc6/gcc49.
See console output.

Failing tests:

projectroot.roottest.root.meta.roottest_root_meta_execUnloading_auto

phsft-bot · 2017-12-04T14:11:55Z

Build failed on slc6/gcc62.
See console output.

Failing tests:

projectroot.roottest.root.meta.roottest_root_meta_execUnloading_auto

phsft-bot · 2017-12-04T14:19:19Z

Build failed on slc6/gcc62.
See console output.

Failing tests:

projectroot.roottest.root.meta.roottest_root_meta_execUnloading_auto

phsft-bot · 2017-12-04T14:27:24Z

Build failed on mac1012/native.
See console output.

Failing tests:

phsft-bot · 2017-12-04T14:29:40Z

Build failed on ubuntu14/native.
See console output.

Failing tests:

projectroot.roottest.root.meta.roottest_root_meta_execUnloading_auto

phsft-bot · 2017-12-04T15:24:46Z

Build failed on ubuntu14/native.
See console output.

Failing tests:

projectroot.roottest.root.meta.roottest_root_meta_execUnloading_auto

Axel-Naumann

👍 Thanks, Vassil!

pcanal · 2017-12-04T17:50:15Z

core/metacling/src/TCling.cxx

+      const VarDecl *CanonVD = cast<VarDecl>(ND)->getCanonicalDecl();
      // Skip if already in the list.
-      if (gROOT->GetListOfGlobals()->FindObject(ND->getNameAsString().c_str()))
+      if (ListOfGlobals->Find(static_cast<DeclId_t>(CanonVD)))


Would be it be better as a const_cast and/or an update to TListOfDataMembers::Find to take a const decl?

I am not sure I understand the const_cast comment. I agree we may want to update TListOfDataMembers::Find as a next step in improving this code.

My bad. I misread the line number in the error messages.

Axel-Naumann · 2017-12-04T20:40:23Z

The behavior shown in the failing test is not what we need, because the old TGlobal object claims it's valid but finding it by name returns a new one. I would not mind discussing whether returning a new TGlobal object from GetListOfGlobals()->FindObject() is a worthwhile backward incompatible change, but then the old TGlobal object must be told that it has been invalidated.

Do you want to update the old TGlobal object and start that discussion? Or do you have a plan B?

phsft-bot · 2017-12-05T08:36:25Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-12-05T08:40:42Z

Build failed on centos7/gcc49.
See console output.

phsft-bot · 2017-12-05T08:40:47Z

Build failed on ubuntu14/native.
See console output.

phsft-bot · 2017-12-05T08:40:52Z

Build failed on mac1012/native.
See console output.

phsft-bot · 2017-12-05T08:43:12Z

Build failed on slc6/gcc62.
See console output.

phsft-bot · 2017-12-05T08:49:08Z

Build failed on slc6/gcc49.
See console output.

phsft-bot · 2017-12-05T08:49:20Z

Build failed on slc6/gcc62.
See console output.

phsft-bot · 2017-12-05T09:05:59Z

Build failed on windows10/vc15.
See console output.

phsft-bot · 2017-12-05T09:07:42Z

Build failed on ubuntu14/native.
See console output.

phsft-bot · 2017-12-05T11:38:28Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-12-05T12:07:07Z

Build failed on mac1012/native.
See console output.

Failing tests:

And 1 more

phsft-bot · 2017-12-05T12:12:05Z

Build failed on slc6/gcc62.
See console output.

Failing tests:

And 4 more

phsft-bot · 2017-12-05T12:25:26Z

Build failed on ubuntu14/native.
See console output.

Failing tests:

And 5 more

phsft-bot · 2017-12-05T12:28:34Z

Build failed on ubuntu14/native.
See console output.

Failing tests:

projectroot.roottest.root.html.roottest_root_html_runMakeIndex

phsft-bot · 2017-12-05T12:29:35Z

Build failed on centos7/gcc49.
See console output.

Failing tests:

And 4 more

phsft-bot · 2017-12-05T12:37:22Z

Build failed on slc6/gcc49.
See console output.

Failing tests:

And 4 more

vgvassilev · 2018-02-15T13:21:16Z

@phsft-bot build!

phsft-bot · 2018-02-15T13:21:28Z

Starting build on centos7/gcc49, mac1013/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu16/native, ubuntu16/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2018-02-15T13:24:04Z

Build failed on slc6/gcc49.
See console output.

Errors:

ERROR: Error fetching remote repo 'origin'
error: Ref refs/remotes/origin/pr/1416/merge is at f2d8280 but expected 712f7dc
error: Ref refs/remotes/origin/pr/1527/head is at f5a6017 but expected d002c98
error: Ref refs/remotes/origin/pr/1527/merge is at 103a2e2 but expected 39a4b34
error: Ref refs/remotes/origin/pr/1563/head is at fc8c366 but expected 36c930a
error: Ref refs/remotes/origin/pr/1563/merge is at a973b1b but expected 002ce5f
error: Ref refs/remotes/origin/pr/1595/merge is at 7fd5f39 but expected 3325d1e
error: Ref refs/remotes/origin/pr/1603/merge is at 576aae7 but expected 7cfbec1
error: Ref refs/remotes/origin/pr/1605/merge is at 0a2564e but expected a6abdb1
error: Ref refs/remotes/origin/pr/1607/merge is at fbe9ab3 but expected 03a9697

And 9 more

phsft-bot · 2018-02-15T13:54:42Z

Build failed on slc6/gcc62.
See console output.

Failing tests:

And 5 more

phsft-bot · 2018-02-15T14:18:32Z

Build failed on ubuntu16/native.
See console output.

Failing tests:

And 5 more

phsft-bot · 2018-02-15T14:33:36Z

Build failed on mac1013/native.
See console output.

Failing tests:

projectroot.roottest.root.html.roottest_root_html_runMakeIndex

phsft-bot · 2018-02-15T14:35:19Z

Build failed on ubuntu16/native.
See console output.

Failing tests:

projectroot.roottest.root.html.roottest_root_html_runMakeIndex

TClingClassInfo has a constructor that is supposed to be used for TU scope lookups. However, it iterates over decls and causes lots of deserializations. It does not respect the C++ lookup rules because it returns the first decl with the name it finds. This patch tries to keep the original behavior by first trying to do a regular lookup and if the result is unambigious it returns the found decl. If the result was ambiguous we try to disambiguate it (by turning off the using directives) and return the found result.

phsft-bot · 2018-02-15T17:47:58Z

Starting build on centos7/gcc49, mac1013/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu16/native, ubuntu16/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

Prevent the following error when ROOT has been built without PyROOT: ``` test 1416 Start 1416: roottest-root-meta-enumPayloadManipulation-checkEnumFwdDecl 1416: Test command: "C:\Program Files\CMake\bin\cmake.exe" "-DCMD=C:/Users/bellenot/AppData/Local/Continuum/miniconda3/python.exe^C:/Users/bellenot/git/roottest/root/meta/enumPayloadManipulation/checkEnumFwdDecl.py^--fixcling" "-DOUT=C:/Users/bellenot/build/x64/release/roottest/root/meta/enumPayloadManipulation/checkEnumFwdDecl.log" "-DOUTREF=C:/Users/bellenot/git/roottest/root/meta/enumPayloadManipulation/empty.ref" "-DERRREF=C:/Users/bellenot/git/roottest/root/meta/enumPayloadManipulation/empty.ref" "-DERR=C:/Users/bellenot/build/x64/release/roottest/root/meta/enumPayloadManipulation/checkEnumFwdDecl.err" "-DCWD=C:/Users/bellenot/build/x64/release/roottest/root/meta/enumPayloadManipulation" "-DDIFFCMD=C:/Users/bellenot/AppData/Local/Continuum/miniconda3/python.exe^C:/Users/bellenot/git/roottest/scripts/custom_diff.py" "-DCHECKOUT=true" "-DCHECKERR=true" "-DSYS=C:/Users/bellenot/build/x64/release" "-DENV=ROOTSYS=C:/Users/bellenot/build/x64/release#PYTHONPATH=C:/Users/bellenot/build/x64/release/bin" "-P" "C:/Users/bellenot/build/x64/release/RootTestDriver.cmake" 1416: Environment variables: 1416: ROOT_HIST=0 1416: Test timeout computed to be: 300 1416: -- TEST COMMAND -- 1416: cd C:/Users/bellenot/build/x64/release/roottest/root/meta/enumPayloadManipulation 1416: C:/Users/bellenot/AppData/Local/Continuum/miniconda3/python.exe C:/Users/bellenot/git/roottest/root/meta/enumPayloadManipulation/checkEnumFwdDecl.py --fixcling 1416: -- BEGIN TEST OUTPUT -- 1416: 1416: -- END TEST OUTPUT -- 1416: -- BEGIN TEST ERROR -- 1416: Traceback (most recent call last): 1416: File "C:/Users/bellenot/git/roottest/root/meta/enumPayloadManipulation/checkEnumFwdDecl.py", line 1, in <module> 1416: import ROOT 1416: ModuleNotFoundError: No module named 'ROOT' 1416: 1416: -- END TEST ERROR -- 1416: CMake Error at C:/Users/bellenot/build/x64/release/RootTestDriver.cmake:181 (message): 1416: got exit code 1 but expected 0 1416: 1416: 3/3 Test root-project#1416: roottest-root-meta-enumPayloadManipulation-checkEnumFwdDecl .....................***Failed 0.14 sec ```

vgvassilev requested a review from pcanal as a code owner December 4, 2017 10:20

vgvassilev force-pushed the AvoidStringVarDeclLookup branch from 04a9e3a to 37a7dde Compare December 4, 2017 10:30

vgvassilev force-pushed the AvoidStringVarDeclLookup branch from 37a7dde to 92effbb Compare December 4, 2017 13:29

root-project deleted a comment from phsft-bot Dec 4, 2017

amadio assigned vgvassilev Dec 4, 2017

Axel-Naumann approved these changes Dec 4, 2017

View reviewed changes

pcanal reviewed Dec 4, 2017

View reviewed changes

vgvassilev force-pushed the AvoidStringVarDeclLookup branch from 70b969f to 906efa4 Compare December 5, 2017 11:38

vgvassilev mentioned this pull request Jan 22, 2018

Autoload canonical namespaces #1547

Merged

vgvassilev force-pushed the AvoidStringVarDeclLookup branch from 906efa4 to 307adf2 Compare February 15, 2018 17:47

vgvassilev merged commit a5a26b8 into root-project:master Feb 15, 2018

vgvassilev deleted the AvoidStringVarDeclLookup branch February 15, 2018 21:25

[cxxmodules] Do not use FindObject when we have the Decl*. #1416

[cxxmodules] Do not use FindObject when we have the Decl*. #1416

Uh oh!

Conversation

vgvassilev commented Dec 4, 2017

Uh oh!

vgvassilev commented Dec 4, 2017

Uh oh!

phsft-bot commented Dec 4, 2017

Uh oh!

phsft-bot commented Dec 4, 2017

Errors:

Uh oh!

phsft-bot commented Dec 4, 2017

Uh oh!

phsft-bot commented Dec 4, 2017

Failing tests:

Uh oh!

phsft-bot commented Dec 4, 2017

Failing tests:

Uh oh!

phsft-bot commented Dec 4, 2017

Failing tests:

Uh oh!

phsft-bot commented Dec 4, 2017

Failing tests:

Uh oh!

phsft-bot commented Dec 4, 2017

Failing tests:

Uh oh!

phsft-bot commented Dec 4, 2017

Failing tests:

Uh oh!

phsft-bot commented Dec 4, 2017

Failing tests:

Uh oh!

Axel-Naumann left a comment

Choose a reason for hiding this comment

Uh oh!

pcanal Dec 4, 2017

Choose a reason for hiding this comment

Uh oh!

vgvassilev Dec 4, 2017

Choose a reason for hiding this comment

Uh oh!

pcanal Dec 4, 2017

Choose a reason for hiding this comment

Uh oh!

Axel-Naumann commented Dec 4, 2017

Uh oh!

phsft-bot commented Dec 5, 2017

Uh oh!

phsft-bot commented Dec 5, 2017

Uh oh!

phsft-bot commented Dec 5, 2017

Uh oh!

phsft-bot commented Dec 5, 2017

Uh oh!

phsft-bot commented Dec 5, 2017

Uh oh!

phsft-bot commented Dec 5, 2017

Uh oh!

phsft-bot commented Dec 5, 2017

Uh oh!

phsft-bot commented Dec 5, 2017

Uh oh!

phsft-bot commented Dec 5, 2017

Uh oh!

phsft-bot commented Dec 5, 2017

Uh oh!

phsft-bot commented Dec 5, 2017

Failing tests:

Uh oh!

phsft-bot commented Dec 5, 2017

Failing tests:

Uh oh!

phsft-bot commented Dec 5, 2017

Failing tests:

Uh oh!

phsft-bot commented Dec 5, 2017