Skip to content

[cxxmodules] Reduce extra deserializations. #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2017
Merged

[cxxmodules] Reduce extra deserializations. #1409

merged 1 commit into from
Dec 1, 2017

Conversation

vgvassilev
Copy link
Member

No description provided.

@vgvassilev vgvassilev requested a review from pcanal as a code owner December 1, 2017 11:25
@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Errors:

  • ERROR: Timeout after 10 minutes
  • ERROR: Error fetching remote repo 'origin'
  • stderr: error: RPC failed; result=18, HTTP code = 200
  • ERROR: Error fetching remote repo 'origin'

@pcanal
Copy link
Member

pcanal commented Dec 1, 2017

You may want to make a note in the commit that the requirement laid down in the (removed) comment are now satisfied (if they are).

@vgvassilev
Copy link
Member Author

That's what I am trying to see if we need that code there. Do you know what series of commits might be addressing it. Which were the commits making the lists lazy?

@vgvassilev
Copy link
Member Author

@phsft-bot build!

@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@vgvassilev
Copy link
Member Author

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

@phsft-bot
Copy link

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Errors:

  • 295/1653 Test documentation: fix legacy definition name #190: tutorial-dataframe-tdf013_InspectAnalysis .........................................................***Failed Error regular expression found in output. Regex=[: error:] 2.48 sec
  • 545/1653 Test [TDF] Add ranges to user guide + a little bit of code formatting #449: tutorial-math-quasirandom .........................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.55 sec
  • 571/1653 Test Fixes to 10 coverity defect reports #480: tutorial-multicore-mtbb201_parallelHistoFill ......................................................***Failed Error regular expression found in output. Regex=[: error:] 3.30 sec
  • 687/1653 Test Utilize git submodules for roottest #599: tutorial-roostats-Zbi_Zgamma ......................................................................***Failed Error regular expression found in output. Regex=[: error:] 7.48 sec
  • 700/1653 Test Resolve warnings reported by -Wnon-virtual-dtor #611: tutorial-roostats-rs_numbercountingutils ..........................................................***Failed Error regular expression found in output. Regex=[: error:] 2.28 sec
  • 734/1653 Test Fix buffer overflow. #651: tutorial-tmva-keras-LaunchClasGUI .................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.82 sec
  • 735/1653 Test Increased tolerance #652: tutorial-tmva-keras-LaunchMultiGUI ................................................................***Failed Error regular expression found in output. Regex=[: error:] 9.38 sec
  • 739/1653 Test Make cling build again on Windows (following the recent changes). To … #653: tutorial-tmva-keras-LaunchRegGUI ..................................................................***Failed Error regular expression found in output. Regex=[: error:] 8.06 sec
  • 779/1653 Test cling PR 162 #702: tutorial-dataframe-tdf002_dataModel-py ............................................................***Failed Error regular expression found in output. Regex=[: error:] 1.99 sec

Warnings:

  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module valarrayDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module map2Dict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimapDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module setDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module listDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multisetDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module vectorDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module dequeDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_setDict:

And 7 more

Failing tests:

And 28 more

@vgvassilev
[cxxmodules] Remove obsolete code. Reduce extra deserializations.
4e3fe55 
ROOT creates lazily the lists of entities. We do not need to actively
update iterate over the namespaces and make the very expensive eager
deserializations which affect the performance for both PCH/PCM.
@phsft-bot
Copy link

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@vgvassilev
Copy link
Member Author

@pcanal, I fixed the commit message and I will merge it. Let me know if you have any objections.

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

@vgvassilev vgvassilev merged commit 467ee9f into root-project:master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcanal pcanal pcanal approved these changes

Assignees

@vgvassilev vgvassilev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgvassilev @phsft-bot @pcanal