[pyroot] adjust GUI events processing #13745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When python non-interactive session runs, there is no any possibility to call callbacks in main thread. Therefore let allow process callbacks directly from the place where data queue is filled.
In interactive python mode processing events always runs from main thread and performed regularly - no special settings are required then
In non-interactive mode one have to run events from special thread, in interactive it should be enough to use input hook
|
Starting build on |
|
Thanks. It works on my local machine which I used to create the reproducer. Let's see what the CI has to say about other platforms. |
dpiparo
requested changes
Sep 28, 2023
It is intended behavior that processing thread may change in python. Therefore display such message only if debug is enabled
|
Starting build on |
|
Build failed on mac12arm/cxx20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, make handling for Mac and Linux similar.
In non-interactive mode run special thread where
gSystem->ProcessEvents()are called.In interactive mode try to use input hook.
In webgui in python non-interactive mode allow to use calling thread for callbacks invocation.
It is the only chance to get processing of http requests from clients.
Probably fixes #13744