-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[cxxmodules] Use the API to load top level system modules. #1344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@phsft-bot just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on |
Starting build on |
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on |
1 similar comment
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on |
Starting build on |
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more Failing tests:
And 48 more |
@phsft-bot build with flags -Druntime_cxxmodules=Off |
Starting build on |
Build failed on slc6/gcc62. Failing tests: |
Can you remove the deletions in this patch, the rest is good to go. (For example this test fails now: https://epsft-jenkins.cern.ch/job/root-pullrequests-build/12169/testReport/projectroot.roottest.root.tree/addresses/roottest_root_tree_addresses_make/ ) |
5db4afe
to
aad45f2
Compare
Starting build on |
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on |
Starting build on |
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more |
PR #1350 supersedes this one. Closing. |
This will allow us to uniformly load all modules tagged as
[system]
. This way we avoid explicitly mentioning the module names (helpful for OSX).