Skip to content

Conversation

@zzxuanyuan
Copy link
Contributor

@bbockelm

  1. I move signal handling from TSystem to a new class called TSigHandling and use gSigHandling as a global signal handling object in ROOT.
  2. To comply with some function calls like "gSystem->ResetSignals()". I move old ResetSignals() to the new class so TUnixSystem::ResetSignals() just call gSigHandling->ResetSignals(). I could also go over all such function calls and replace them with gSigHandling->(functions) if necessary.
  3. I replace old unsafe functions in signal handlers with thread-safe ones.
  4. I only implement StackTrace functions for SIGBUS, SIGSEGV, SIGILL. Other signals are still using default StackTrace functions. kSigAlarm and kSigChild are ignored for my current implementation. Do we need to change other signal handlers?
  5. @pcanal I have some problem with running roottest. I asked a question here:
    Fix issue ROOT-7588. #84
    Could you take a look at it and I will write test case this patch also.

@zzxuanyuan zzxuanyuan closed this Jan 21, 2016
@zzxuanyuan zzxuanyuan deleted the sigtest branch January 21, 2016 05:02
// //
//////////////////////////////////////////////////////////////////////////

#ifndef __CINT__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ifndef CINT are no longer needed as it is (in v6) never defined

@pcanal pcanal self-assigned this Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants