[cxxmodules] Also load TreePlayer to fix TDataFrame tests. #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without modules, many STL and libc headers are automatically
provided by ROOT via the attached ROOT PCH. This means that
we don't need to have autloading or explicit includes for STL
or libc headers when running with the PCH attached. This leads
to making user code like this working in ROOT:
```C++
// no includes here that provides assert
int foo() {
assert(false);
}
```
However, as the modules don't come with this big PCH, we
are now suddenly in the situation where we can't resolve
things such as `assert`. We also can't rely on the
normal autoloading of ROOT as those declarations were
actually never autoloaded, but just provided by the PCH.
To simulate this behavior with modules, we automatically load
those headers that we expect to have in the ROOT PCH
(which are probably the STL and libc headers).
If we preload the core modules that can contain complex.h, we break a lot of tests that name variables or template arguments I.
It seems automatically loading TreePlayer when TDataFrame is used without the appropriate include never worked. This was previously fixed by just adding TreePlayer (which contains TDF) to the PCH. As always, let's recreate this hack with modules to make restore the old behavior with modules turned on.
|
Starting build on |
|
@phsft-bot build with flags -Druntime_cxxmodules=On |
|
Starting build on |
|
Build failed on mac1012/native. Errors:
And 10 more |
|
Build failed on centos7/gcc49. Errors:
Warnings:
And 7 more |
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more |
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more |
|
Build failed on slc6/gcc49. Errors:
Warnings:
And 7 more |
|
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=On |
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more |
|
We first need to fix the dependencies that TreePlayer is built before we try to load it. |
|
That would require building quite a lot of root... |
|
EDIT: Nvm, that would be the same principle with a horrible implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #1317, adds only one other commit: