Skip to content

Conversation

Neel-Shah-29
Copy link
Contributor

This Pull request: Implements the Range ONNX Operator

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@phsft-bot
Copy link

Can one of the admins verify this patch?

@Neel-Shah-29
Copy link
Contributor Author

@lmoneta @sanjibansg
I am getting the below error for the renge operator, can you please help me with it? I think the error is due to the stod function used to convert string input to double.
image

@Neel-Shah-29 Neel-Shah-29 changed the title [GSOC][TMVA][SOFIE]Range ONNX Operator implemented successfully [GSOC][TMVA][SOFIE] Implemented the Range ONNX Operator in SOFIE Jun 3, 2023
void Initialize(RModel &model)
{
// input must be a scalar
double lim = std::stod(fNLimit);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure the inputs to the Range operator in ONNX are actually a double value but in a string? I thought it would have a string name to represent in the model, and it will take up values as passed or present in the model.

@sanjibansg
Copy link
Contributor

@lmoneta @sanjibansg I am getting the below error for the renge operator, can you please help me with it? I think the error is due to the stod function used to convert string input to double. image

I think this is because the string inputs that the operator is receiving actually do not contains any double value, which is expected, as ONNX model inputs usually takes up strings to represent their values rather than actually encoding them to strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants