Skip to content

Conversation

@hahnjo
Copy link
Member

@hahnjo hahnjo commented May 8, 2023

No description provided.

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2023-05-08T09:28:45.803Z] FAILED: tmva/pymva/test/CMakeFiles/SofieCompileModels_PyTorch.util

@github-actions
Copy link

github-actions bot commented May 8, 2023

Test Results

         7 files           7 suites   1d 19h 9m 23s ⏱️
  2 433 tests   2 213 ✔️ 0 💤 220
16 792 runs  16 553 ✔️ 0 💤 239

For more details on these failures, see this check.

Results for commit 68617ff.

♻️ This comment has been updated with latest results.

Copy link
Member

@Axel-Naumann Axel-Naumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge the RooFit part, if these comparisons fail it's a real failure that @egpbos is investigating, as he explained in this PR:

#12389

It's exactly the point of the test that the results should be the same bit-wise.

If you want green builds 🍏 I suggest to disable this test on mac13arm with a comment.

@hahnjo
Copy link
Member Author

hahnjo commented May 8, 2023

It's exactly the point of the test that the results should be the same bit-wise.

I don't understand why you want this, I will comment on the other PR.

If you want green builds 🍏 I suggest to disable this test on mac13arm with a comment.

Yes, we should always have green builds, and in my opinion it's very unfortunate that we have known-failing tests on a significant platform for months.

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

@hahnjo hahnjo dismissed guitargeek’s stale review May 10, 2023 13:13

Removed the RooFit commit, discussion in #12389 which should be merged eventually

@hahnjo hahnjo merged commit f237213 into root-project:master May 10, 2023
@hahnjo hahnjo deleted the mac13arm branch May 10, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants