-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Test fixes for mac13arm #12784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test fixes for mac13arm #12784
Conversation
|
Starting build on |
|
Build failed on ROOT-ubuntu2004/python3. Errors:
|
|
Build failed on windows10/cxx14. Failing tests: |
Axel-Naumann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't merge the RooFit part, if these comparisons fail it's a real failure that @egpbos is investigating, as he explained in this PR:
It's exactly the point of the test that the results should be the same bit-wise.
If you want green builds 🍏 I suggest to disable this test on mac13arm with a comment.
I don't understand why you want this, I will comment on the other PR.
Yes, we should always have green builds, and in my opinion it's very unfortunate that we have known-failing tests on a significant platform for months. |
The test currently fails on mac13arm.
|
Starting build on |
Removed the RooFit commit, discussion in #12389 which should be merged eventually
No description provided.