[RF] Fix duplicate ownership problem in RooMomentMorph(Func)ND #12160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit 4c9c5d6 fixed the memory leaking of the `RooMomentMorph(Func)ND::Grid2::_grid` member by deleting it in the constructor, but it didn't consider that the copy constructor didn't make a clone of the `_grid`, ending up with double ownership. Now, the copy constructor is also cloning the binnings, just like the regular constructor, and the double ownership is avoided. Closes root-project#12155.
|
Starting build on |
|
Build failed on ROOT-ubuntu2004/python3. |
|
Build failed on mac12/noimt. Warnings:
|
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 4c9c5d6 fixed the memory leaking of the
RooMomentMorph(Func)ND::Grid2::_gridmember by deleting it in the constructor, but it didn't consider that the copy constructor didn't make a clone of the_grid, ending up with double ownership.Now, the copy constructor is also cloning the binnings, just like the regular constructor, and the double ownership is avoided.
Closes #12155.