CMake: fix incorrect version for finding llvm-config #12150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephan Lachnit <stephanlachnit@debian.org>
|
Can one of the admins verify this patch? |
Member
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-ubuntu2004/python3. |
Member
|
@phsft-bot build just on ROOT-ubuntu2004/python3 |
|
Starting build on |
|
Build failed on ROOT-ubuntu2004/python3. |
hahnjo
approved these changes
Jan 30, 2023
Member
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
Not sure why the clone of root.git fails on Ubuntu 20.04, but seems unrelated to the changes here.
Axel-Naumann
pushed a commit
that referenced
this pull request
Jan 30, 2023
Signed-off-by: Stephan Lachnit <stephanlachnit@debian.org> (cherry picked from commit 37b2521)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Fixes that CMake was still trying to look for
llvm-config-9instead ofllvm-config-13after for #10294.To prevent this I added two variable in the beginning of the file so that it is less likely to be forgotten next time. I also moved the versioned version before the unversioned one. This should make sure it actually takes the right version if
llvm-configdefaults to a version that is not 13 (currently the case in Debian e.g.)./cc @hahnjo @vgvassilev @bellenot
Checklist: