[RF] RooProduct schema-evolved i/o bug fix #12071

will-cern · 2023-01-20T11:48:57Z

handle case where p0 or p1 are null -> ensure not null by time expectProxyIs is called

phsft-bot · 2023-01-20T11:49:00Z

Can one of the admins verify this patch?

guitargeek

Thanks for the fix and also taking care of the typo!

guitargeek · 2023-01-20T11:50:02Z

@phsft-bot build

phsft-bot · 2023-01-20T11:50:08Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-01-20T13:47:49Z

Build failed on mac12/noimt.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Warnings:

[2023-01-20T12:54:42.293Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/core/base/src/TDirectory.cxx:1245:7: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]

Failing tests:

And 62 more

phsft-bot · 2023-01-20T14:12:52Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-01-20T18:38:33Z

Build failed on mac11/cxx14.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

guitargeek · 2023-01-22T11:57:59Z

Before merging, I profit from this PR to fix another typo that caused a bug when copying a RooGenProdProj.

guitargeek · 2023-01-22T11:58:13Z

@phsft-bot build

phsft-bot · 2023-01-22T11:58:19Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-01-22T12:07:11Z

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-3.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-01-22T12:06:56.459Z] FAILED: tmva/sofie/test/CMakeFiles/SofieCompileModels_ONNX.util

phsft-bot · 2023-01-22T12:29:58Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-01-22T12:37:30Z

Build failed on mac12/noimt.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Warnings:

[2023-01-22T12:04:20.315Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/core/base/src/TDirectory.cxx:1297:7: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]

Failing tests:

And 70 more

phsft-bot · 2023-01-22T13:00:43Z

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-01-22T13:09:01Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-01-22T13:21:34Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

Handle case where p0 or p1 are null -> ensure not null by time expectProxyIs is called.

phsft-bot · 2023-01-22T14:25:06Z

Build failed on mac11/cxx14.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

And 9 more

guitargeek · 2023-01-22T16:18:54Z

@phsft-bot build

phsft-bot · 2023-01-22T16:19:00Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-01-22T16:24:16Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2023-01-22T16:24:13.229Z] C:/build/workspace/root-pullrequests-build/build/etc\cling/Interpreter/RuntimeUniverse.h:27:10: fatal error: could not build module 'Cling_Runtime_Extra'
[2023-01-22T16:24:13.229Z] input_line_2:1:10: fatal error: could not build module 'Cling_Runtime'
[2023-01-22T16:24:15.138Z] C:/build/workspace/root-pullrequests-build/build/include\Rtypes.h:23:10: fatal error: could not build module 'ROOT_Rtypes'
[2023-01-22T16:24:15.409Z] C:/build/workspace/root-pullrequests-build/build/include/ThreadLocalStorage.h:60:10: fatal error: could not build module 'ROOT_Rtypes'
[2023-01-22T16:24:15.409Z] CUSTOMBUILD : fatal error : too many errors emitted, stopping now [-ferror-limit=] [C:\build\workspace\root-pullrequests-build\build\core\G__Core.vcxproj]

phsft-bot · 2023-01-22T16:26:59Z

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2023-01-22T16:26:49.200Z] FAILED: tmva/sofie/test/CMakeFiles/SofieCompileModels_ONNX.util

phsft-bot · 2023-01-22T16:57:40Z

Build failed on mac12/noimt.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Warnings:

[2023-01-22T16:26:09.511Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/core/base/src/TDirectory.cxx:1297:7: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]

Failing tests:

And 62 more

phsft-bot · 2023-01-22T18:47:40Z

Build failed on mac11/cxx14.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

will-cern requested review from guitargeek, hageboeck and lmoneta as code owners January 20, 2023 11:48

guitargeek approved these changes Jan 20, 2023

View reviewed changes

jalopezg-git assigned guitargeek Jan 20, 2023

jalopezg-git added the in:RooFit/RooStats label Jan 20, 2023

jalopezg-git changed the title ~~RooProduct schema-evolved i/o bug fix~~ [RF] RooProduct schema-evolved i/o bug fix Jan 20, 2023

guitargeek force-pushed the rooproduct_proxybugfix branch from 8400321 to c447816 Compare January 22, 2023 11:57

guitargeek mentioned this pull request Jan 22, 2023

[RF] RooFit open issues and backports for 6.28.00 release #11856

Closed

52 tasks

guitargeek mentioned this pull request Jan 22, 2023

[v628][RF] Backports of RooFit PRs to v6-28-00-patches: Part 6 #12083

Merged

will-cern and others added 2 commits January 22, 2023 15:11

[RF] RooProduct schema-evolved i/o bug fix

ef1b511

Handle case where p0 or p1 are null -> ensure not null by time expectProxyIs is called.

[RF] Fix implementation error from typo in RooGenProdProj

4cbe892

guitargeek force-pushed the rooproduct_proxybugfix branch from c447816 to 4cbe892 Compare January 22, 2023 14:11

guitargeek merged commit f457ca5 into root-project:master Jan 22, 2023

[RF] RooProduct schema-evolved i/o bug fix #12071

[RF] RooProduct schema-evolved i/o bug fix #12071

Uh oh!

Conversation

will-cern commented Jan 20, 2023

Uh oh!

phsft-bot commented Jan 20, 2023

Uh oh!

guitargeek left a comment

Choose a reason for hiding this comment

Uh oh!

guitargeek commented Jan 20, 2023

Uh oh!

phsft-bot commented Jan 20, 2023

Uh oh!

phsft-bot commented Jan 20, 2023

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Jan 20, 2023

Failing tests:

Uh oh!

phsft-bot commented Jan 20, 2023

Failing tests:

Uh oh!

guitargeek commented Jan 22, 2023

Uh oh!

guitargeek commented Jan 22, 2023

Uh oh!

phsft-bot commented Jan 22, 2023

Uh oh!

phsft-bot commented Jan 22, 2023

Errors:

Uh oh!

phsft-bot commented Jan 22, 2023

Failing tests:

Uh oh!

phsft-bot commented Jan 22, 2023

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Jan 22, 2023

Failing tests:

Uh oh!

phsft-bot commented Jan 22, 2023

Failing tests:

Uh oh!

phsft-bot commented Jan 22, 2023

Failing tests:

Uh oh!

phsft-bot commented Jan 22, 2023

Failing tests:

Uh oh!

guitargeek commented Jan 22, 2023

Uh oh!

phsft-bot commented Jan 22, 2023

Uh oh!

phsft-bot commented Jan 22, 2023

Errors:

Uh oh!

phsft-bot commented Jan 22, 2023

Errors:

Uh oh!

phsft-bot commented Jan 22, 2023

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Jan 22, 2023

Failing tests:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants