Revert "[cmake] Xcode 14 warns about -undefined dynamic_lookup; simply suppress:" #12045

Axel-Naumann · 2023-01-17T16:38:20Z

See #11937 for why -flat_namespace is bad.

This reverts commit a05d4be.

This PR fixes #11937

…ply suppress:" See root-project#11937 for why `-flat_namespace` is bad. This reverts commit a05d4be.

phsft-bot · 2023-01-17T16:38:28Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-01-17T17:10:22Z

Build failed on mac12/noimt.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Warnings:

[2023-01-17T16:45:33.503Z] ld: warning: -undefined dynamic_lookup may not work with chained fixups
[2023-01-17T16:45:34.292Z] ld: warning: -undefined dynamic_lookup may not work with chained fixups
[2023-01-17T16:45:41.485Z] ld: warning: -undefined dynamic_lookup may not work with chained fixups
[2023-01-17T16:45:49.589Z] ld: warning: -undefined dynamic_lookup may not work with chained fixups

pcanal · 2023-01-17T17:56:43Z

Additional mention of the original issue (chained lookups): https://developer.apple.com/forums/thread/719961, python/cpython#97524
and https://openradar.appspot.com/radar?id=5536824084660224.

Instead of -Wl,-w (which suppress all warnings), an undocumented options seems to be -Xlinker -no_fixup_chains (humm I guess actually maybe -Wl,-no_fixup_chains)

pcanal

With a few more -Wl,-w it should work (or maybe we could disable the chained fixups)

bindings/jupyroot/CMakeLists.txt

bindings/pyroot/cppyy/CPyCppyy/CMakeLists.txt

bindings/pyroot/pythonizations/CMakeLists.txt

Axel-Naumann · 2023-01-18T09:55:26Z

Instead of -Wl,-w (which suppress all warnings), an undocumented options seems to be -Xlinker -no_fixup_chains (humm I guess actually maybe -Wl,-no_fixup_chains)

I am afraid that older linkers will not know -no_fixup_chains as that seems to be a new concern. So -w it is.

phsft-bot · 2023-01-18T09:55:59Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-01-18T09:56:06Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

See root-project#11937 for why that is currently needed. `flat_namespace` is not a solution.

phsft-bot · 2023-01-18T15:03:17Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-01-18T15:03:49Z

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2023-01-18T15:03:48.332Z] CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
[2023-01-18T15:03:48.588Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1210 (message):

pcanal · 2023-01-18T17:09:51Z

I am afraid that older linkers will not know -no_fixup_chains as that seems to be a new concern.

Did you try on the oldest (not that old :)) XCode we support?

Axel-Naumann · 2023-01-18T17:20:52Z

My ld:

$ ld -no_fixup_chains /dev/null -o /dev/null
ld: warning: platform not specified
ld: warning: -arch not specified
ld: warning: No platform min-version specified on command line
ld: file too small (length=0) file '/dev/null' for architecture unknown

On 10.15 (i.e. just dead):

$ ld -no_fixup_chains /dev/null -o /dev/null
ld: unknown option: -no_fixup_chains

q.e.d. :-)

phsft-bot · 2023-01-18T17:21:18Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

pcanal · 2023-01-18T17:45:58Z

On 10.15 (i.e. just dead):

If Apple is not supporting it (since 4 months ago), do we still need to support it? (Labs/IT should already no longer allow them on their network).

Axel-Naumann · 2023-01-19T07:13:22Z

macOS 11:

% ld -no_fixup_chains /dev/null -o /dev/null
ld: unknown option: -no_fixup_chains

Axel-Naumann · 2023-01-19T07:15:42Z

The Windows "failure" seems spurious:

18:21:16  Build failed because:
[Pipeline] echo
18:21:16  hudson.AbortException: script returned exit code -1

even though all tests have passed.

Axel-Naumann · 2023-01-19T07:16:13Z

@phsft-bot build just on ROOT-performance-centos8-multicore/cxx17

phsft-bot · 2023-01-19T07:16:20Z

Starting build on ROOT-performance-centos8-multicore/cxx17
How to customize builds

Axel-Naumann · 2023-01-23T16:53:45Z

v6-28: #12100

Revert "[cmake] Xcode 14 warns about -undefined dynamic_lookup; sim…

351a0a0

…ply suppress:" See root-project#11937 for why `-flat_namespace` is bad. This reverts commit a05d4be.

Axel-Naumann added this to the 6.28/00 milestone Jan 17, 2023

Axel-Naumann requested a review from bellenot January 17, 2023 16:38

Axel-Naumann requested a review from pcanal as a code owner January 17, 2023 16:38

Axel-Naumann self-assigned this Jan 17, 2023

pcanal approved these changes Jan 17, 2023

View reviewed changes

bindings/jupyroot/CMakeLists.txt Outdated Show resolved Hide resolved

bindings/pyroot/cppyy/CPyCppyy/CMakeLists.txt Outdated Show resolved Hide resolved

bindings/pyroot/pythonizations/CMakeLists.txt Outdated Show resolved Hide resolved

[cmake] Silence macOS linker warnings on -undefined dynamic_lookup:

fccb8de

See root-project#11937 for why that is currently needed. `flat_namespace` is not a solution.

Axel-Naumann force-pushed the macos-ld-no-flat-namespace branch from d4d5827 to fccb8de Compare January 18, 2023 15:03

Axel-Naumann merged commit 5ad4ab9 into root-project:master Jan 19, 2023

Axel-Naumann deleted the macos-ld-no-flat-namespace branch January 19, 2023 11:52

Revert "[cmake] Xcode 14 warns about -undefined dynamic_lookup; simply suppress:" #12045

Revert "[cmake] Xcode 14 warns about -undefined dynamic_lookup; simply suppress:" #12045

Uh oh!

Conversation

Axel-Naumann commented Jan 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phsft-bot commented Jan 17, 2023

Uh oh!

phsft-bot commented Jan 17, 2023

Warnings:

Uh oh!

pcanal commented Jan 17, 2023

Uh oh!

pcanal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Axel-Naumann commented Jan 18, 2023

Uh oh!

phsft-bot commented Jan 18, 2023

Uh oh!

phsft-bot commented Jan 18, 2023

Uh oh!

phsft-bot commented Jan 18, 2023

Uh oh!

phsft-bot commented Jan 18, 2023

Errors:

Uh oh!

pcanal commented Jan 18, 2023

Uh oh!

Axel-Naumann commented Jan 18, 2023

Uh oh!

phsft-bot commented Jan 18, 2023

Uh oh!

pcanal commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Axel-Naumann commented Jan 19, 2023

Uh oh!

Axel-Naumann commented Jan 19, 2023

Uh oh!

Axel-Naumann commented Jan 19, 2023

Uh oh!

phsft-bot commented Jan 19, 2023

Uh oh!

Axel-Naumann commented Jan 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Axel-Naumann commented Jan 17, 2023 •

edited

Loading

pcanal commented Jan 18, 2023 •

edited

Loading