[RF] Fix IO and memory problems in RooMomentMorph(Func)ND #12039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
The member that points to the last normalization set should not take part in IO. Also, a memory leak is fixed and some code is modernized by using `std::unique_ptr`.
guitargeek
force-pushed
the
issue-11876
branch
from
fd8adda to
307157a
Compare
|
Starting build on |
|
Build failed on windows10/cxx14. Failing tests: |
pcanal
approved these changes
Jan 16, 2023
This was referenced Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The member that points to the last normalization set should not take part in IO.
Also, a memory leak is fixed and some code is modernized by using
std::unique_ptr.