[RF] New public accessor methods for various roofit data members #12030
Conversation
will-cern
requested review from
guitargeek,
hageboeck and
lmoneta
as code owners
|
Can one of the admins verify this patch? |
| void selectComp(bool flag) { | ||
| // If flag is true, only selected component will be included in evaluates of RooAddPdf components | ||
| _selectComp = flag ; | ||
| } |
There was a problem hiding this comment.
| void selectComp(bool flag) { | |
| // If flag is true, only selected component will be included in evaluates of RooAddPdf components | |
| _selectComp = flag ; | |
| } | |
| /// If flag is true, only selected component will be included in evaluates of RooAddPdf components | |
| void selectComp(bool flag) { | |
| _selectComp = flag ; | |
| } |
Don't bother doing it now, but for the next time if you are changing the code and stumble across the old documentation strings, please take the opportunity to update them to the doxygen format (/// and . at the end).
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
LGTM, not really controversial changes indeed! All the data member that are now publicly accessible before were already protected before, so basically public already. Only the _namedSets in the RooWorkspace was private, but it's content was already accessible to the user anyway via RooWorkspace::set().
guitargeek
changed the title
|
@phsft-bot build |
|
Starting build on |
3 participants
A set of, hopefully, non-controversial changes to some roofit classes to allow certain data members to be accessed publicly.