[RF] Add cloneAndOwnDataHist() method to RooHistFunc and RooHistPdf
#12029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing dataHist in order to take ownership of it
will-cern
requested review from
guitargeek,
hageboeck and
lmoneta
as code owners
|
Can one of the admins verify this patch? |
Contributor
|
@phsft-bot build |
guitargeek
requested changes
Jan 13, 2023
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Hi, thanks for the contribution!
I have only one request: can you please put the definitions in the cxx files, with the documentation? If the definition is in the header file, the compiler might inline the function, which is great if the function is cheap and the call overhead is large, but in general it makes debugging harder because there is no stack trace for the call, also binaries are a bit larger then.
52 tasks
guitargeek
changed the title
cloneAndOwnDataHist() method to RooHistFunc and RooHistPdf
guitargeek
approved these changes
Jan 15, 2023
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Thanks for implementing this new method and taking care of the review comments!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation is in comments for new methods - allows underlying dataHist to be cloned if necessary to take ownership