[RF] More improvements to roofitcore unit tests
#11995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good testing is imporant, so it's also important to follow predictable conventions in unit tests. In RooFit, we have established that the name of all test files should match the `test*.cxx` patters. In this commit, all the files that don't match this pattern are renamed, and code-formatted on this occasion. Also, all the files in `roofit/roofitcore/test/TestStatistics` are reformatted because they almost followed the style anyway.
So far, most of the `RooNLLVar` test in `testTestStatistics` were hardcoded to only cover the BatchMode, but it's good if they also cover the legacy RooFit. Hence, all these tests were converted to parameterized tests that cover the BatchMode `"off"` and `"cpu"`. In the same go, all the unit tests in the same file are updated to silence unnecessary info printout.
guitargeek
requested review from
bellenot,
hageboeck and
lmoneta
as code owners
|
Starting build on |
52 tasks
guitargeek
force-pushed
the
roofitcore_tests_1
branch
from
b2456b4 to
2eda409
Compare
|
Starting build on |
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Warnings:
And 1 more |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Warnings:
And 51 more |
|
Build failed on mac12/noimt. Warnings:
|
|
Build failed on ROOT-ubuntu2004/python3. Warnings:
|
|
Build failed on mac11/cxx14. Warnings:
|
* The ERROR printouts in the `createNLLModularLAndOffset` test are actually expected, so we now silence them using the "hijack" mechanism and check if they are inside the string * The `fitTo` test uses the multiprocess parallelization and can be turned on if roofit was built with `multiprocess` * Some memory leaks were fixed too
|
Starting build on |
guitargeek
force-pushed
the
roofitcore_tests_1
branch
from
9ac2873 to
dfed051
Compare
|
Starting build on |
|
Build failed on mac12/noimt. Warnings:
|
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Warnings:
|
|
Build failed on ROOT-ubuntu2004/python3. Warnings:
|
It's better to use Asimov datasets in the bin integration tests, because like this there is no randomness and it's much easier to separate bias from variance (as there is no variance). Also, this commit avoids some code duplication in `testTestStatistics`
guitargeek
force-pushed
the
roofitcore_tests_1
branch
from
dfed051 to
d406f6a
Compare
|
Starting build on |
Contributor
Author
|
Just a little fixup to fix the warning |
lmoneta
approved these changes
Jan 10, 2023
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
Thank you Jonas for the improvements in the tests!
|
Build failed on mac11/cxx14. Errors:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detail in the commit descriptions.