[RF] Fix copy-paste error in rf205 tutorial and related stressRooFit test
#11985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
guitargeek
changed the title
rf205 tutorial and related stressRooFit test
|
Build failed on mac12/noimt. Warnings:
And 53 more Failing tests:
|
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Errors:
Warnings:
And 130 more Failing tests:
|
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Warnings:
And 60 more Failing tests:
|
|
Build failed on mac11/cxx14. Errors:
Warnings:
And 54 more Failing tests:
|
lmoneta
approved these changes
Jan 9, 2023
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
Thank you Jonas for fixing this.
I have just a comment on the title of the pdf representing the total background.
tutorials/roofit/rf205_compplot.C
Outdated
| RooRealVar bkg1frac("sig1frac", "fraction of component 1 in background", 0.2, 0., 1.); | ||
| RooAddPdf bkg("bkg", "Signal", RooArgList(bkg1, bkg2), sig1frac); | ||
| RooRealVar bkg1frac("bkg1frac", "fraction of component 1 in background", 0.8, 0., 1.); | ||
| RooAddPdf bkg("bkg", "Signal", {bkg1, bkg2}, bkg1frac); |
Contributor
Author
There was a problem hiding this comment.
Thanks for spotting this!
tutorials/roofit/rf205_compplot.py
Outdated
| bkg1frac = ROOT.RooRealVar("sig1frac", "fraction of component 1 in background", 0.2, 0.0, 1.0) | ||
| bkg = ROOT.RooAddPdf("bkg", "Signal", [bkg1, bkg2], [sig1frac]) | ||
| bkg1frac = ROOT.RooRealVar("bkg1frac", "fraction of component 1 in background", 0.8, 0.0, 1.0) | ||
| bkg = ROOT.RooAddPdf("bkg", "Signal", [bkg1, bkg2], [bkg1frac]) |
Member
There was a problem hiding this comment.
Same comment as before for the C++ version of the tutorial
test/stressRooFit_tests.h
Outdated
| RooRealVar bkg1frac("sig1frac","fraction of component 1 in background",0.2,0.,1.) ; | ||
| RooAddPdf bkg("bkg","Signal",RooArgList(bkg1,bkg2),sig1frac) ; | ||
| RooRealVar bkg1frac("bkg1frac","fraction of component 1 in background",0.8,0.,1.) ; | ||
| RooAddPdf bkg("bkg", "Signal", {bkg1,bkg2}, bkg1frac); |
Member
There was a problem hiding this comment.
Also the title of the pdf should be changed to something like "Total Background"
52 tasks
guitargeek
force-pushed
the
tutorial_fix
branch
from
9f60d3f to
f51f85f
Compare
|
Starting build on |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Errors:
Warnings:
And 130 more Failing tests:
|
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Warnings:
And 60 more Failing tests:
|
|
Build failed on mac12/noimt. Warnings:
And 53 more Failing tests:
|
|
Build failed on mac11/cxx14. Errors:
Warnings:
And 54 more Failing tests:
|
In the `rf205` tutorial and the associated stressRooFit test, the `bkg` RooAddPdf was created using the `sig1frac`, while it is clearly the idea to use the `bkg1frac` parameter. This is fixed in this commit, also fixing the name of the `bkg1frac` parameter, which was accidentally set to `sig1frac` (probably a copy-paste error). However, to not change the output of the tutorial and the stressRooFit test, the value of `bkg1frac` was set to the same value as `sig1frac`, such that this commit only fixes the model but doesn't change the tutorial and test output.
guitargeek
force-pushed
the
tutorial_fix
branch
from
f51f85f to
32fded3
Compare
|
Starting build on |
|
Build failed on mac12/noimt. Warnings:
And 53 more Failing tests:
|
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Warnings:
And 130 more Failing tests:
|
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Warnings:
And 60 more Failing tests:
|
|
Build failed on mac11/cxx14. Warnings:
And 54 more Failing tests:
|
|
Build failed on ROOT-ubuntu2004/python3. Errors:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
rf205tutorial and the associated stressRooFit test, thebkgRooAddPdf was created using thesig1frac, while it is clearly the idea to use thebkg1fracparameter.This is fixed in this commit, also fixing the name of the
bkg1fracparameter, which was accidentally set tosig1frac(probably a copy-paste error).However, to not change the output of the tutorial and the stressRooFit test, the value of
bkg1fracwas set to the same value assig1frac, such that this commit only fixes the model but doesn't change the tutorial and test output.