[RF] Prevent accidental casting from double to int in xroofit
#11984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGCarroll
requested review from
guitargeek,
hageboeck and
lmoneta
as code owners
|
Can one of the admins verify this patch? |
guitargeek
reviewed
Jan 7, 2023
guitargeek
requested changes
Jan 7, 2023
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Hi @MrCarroll, thank you very much for your PR!
I think it would be better to address the underlying problem of why it thinks the first argument is an int. My suspicion is that the problem is the usage of abs and not std::abs, because abs has no overload for doubles. By passing a double to abs without std::, it gets rounded to an int depending on your environment. This is a bug that just casting back to double afterwards doesn't fix: you have to use the right std::abs function to begin with.
Can you please check if this makes sense, by trying my suggestion in your snap environment, and if it works update your PR?
Thanks again!
guitargeek
changed the title
On the Snap build of ROOT, the parameters were assumed to be int, double
Contributor
|
@phsft-bot build |
|
Starting build on |
guitargeek
approved these changes
Jan 7, 2023
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
LGTM, thank you for the fix!
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Warnings:
And 60 more Failing tests:
|
|
Build failed on mac12/noimt. Warnings:
And 53 more Failing tests:
|
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Warnings:
And 130 more Failing tests:
|
|
Build failed on mac11/cxx14. Warnings:
And 54 more Failing tests:
|
52 tasks
guitargeek
changed the title
double to int in xroofit
|
Build failed on ROOT-ubuntu2004/python3. Warnings:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Snap build of ROOT, the parameters were assumed to be int, double
Errors from build log, running Ubuntu 20.04 GCC9 C++17
This doesn't appear to occur in normal builds, but the guard code seems trivial enough to include and this may prevent compilation errors in other scenarios.
Checklist: