[tmva][sofie] Exclude SOFIE test when blas is not found #11721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
Member
Author
|
@phsft-bot build just on ROOT-ubuntu2204/cxx17, ROOT-ubuntu2004/noimt, ROOT-ubuntu18.04/nortcxxmod |
|
Starting build on |
|
Build failed on ROOT-ubuntu2204/cxx17. Failing tests: |
bellenot
approved these changes
Nov 16, 2022
guitargeek
added a commit
to guitargeek/root
that referenced
this pull request
Mar 19, 2025
In principle, `tmva-cpu` and `tmva-sofie` are separate features, and they should not be entangled. Since PR root-project#11721, the `tmva-cpu` variable is used as a proxy to detect whether BLAS is on the system or not, to conditionally disable some SOFIE tests. This means one would lose SOFIE test coverage when disabling `tmva-cpu`, which is not necessary. This commit suggests to always build the SOFIE tests that require BLAS.
guitargeek
added a commit
to guitargeek/root
that referenced
this pull request
Mar 19, 2025
In principle, `tmva-cpu` and `tmva-sofie` are separate features, and they should not be entangled. Since PR root-project#11721, the `tmva-cpu` variable is used as a proxy to detect whether BLAS is on the system or not, to conditionally disable some SOFIE tests. This means one would lose SOFIE test coverage when disabling `tmva-cpu`, which is not necessary. This commit suggests to always build the SOFIE tests that require BLAS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request exclude running of SOFIE tests when Blas is not found (this is when
tmva-cpu=Off)