-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[bugfix] Update SimplexBuilder.cxx to fix #6775 #10492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-performance-centos8-multicore/default. Errors:
|
|
Build failed on ROOT-debian10-i386/cxx14. Errors:
|
|
Build failed on ROOT-ubuntu2004/soversion. Errors:
|
|
Build failed on ROOT-ubuntu16/nortcxxmod. Errors:
|
|
Build failed on mac11/cxx17. Errors:
|
|
Build failed on windows10/cxx14. Errors:
|
|
Build failed on mac1015/python3. Errors:
|
|
@phsft-bot build |
|
Starting build on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the fix! I'll merge this later when the CI is done.
I have updated the PR with a more sustainable fix that returns the minimum state early. Otherwise, there other undefined floating point behavior down the line.
This avoids the problems when running simplex with zero parameters reported in root-project#6775.
|
@phsft-bot build |
|
Starting build on |
Should fix #6775