Skip to content

Conversation

@andriish
Copy link
Contributor

Should fix #6775

@andriish andriish requested a review from lmoneta as a code owner April 29, 2022 11:46
@phsft-bot
Copy link

Can one of the admins verify this patch?

@guitargeek
Copy link
Contributor

@phsft-bot build

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-05-02T11:01:01.232Z] -- VDT install command succeeded. See also /data/sftnight/workspace/root-pullrequestsCMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

@phsft-bot
Copy link

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-05-02T11:02:26.454Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-05-02T11:02:51.515Z] FAILED: builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download
  • [2022-05-02T11:02:51.515Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

@phsft-bot
Copy link

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-05-02T11:02:42.556Z] FAILED: cd /mnt/build/workspace/root-pullrequests-build/build/builtins/xrootd/XROOTD-prefix/src && /usr/bin/cmake -P /mnt/build/workspace/root-pullrequests-build/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download-Release.cmake && /usr/bin/cmake -E touch /mnt/build/workspace/root-pullrequests-build/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download
  • [2022-05-02T11:02:42.556Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

@phsft-bot
Copy link

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-05-02T11:06:38.911Z] FAILED: builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download /Users/sftnight/build/workspace/root-pullrequests-build/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download
  • [2022-05-02T11:06:38.911Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

@phsft-bot
Copy link

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

  • [2022-05-02T11:10:36.255Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

@phsft-bot
Copy link

Build failed on mac1015/python3.
Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-05-02T11:30:50.742Z] FAILED: builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download /Volumes/HD2/build/workspace/root-pullrequests-build/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download
  • [2022-05-02T11:30:50.742Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

@guitargeek
Copy link
Contributor

@phsft-bot build

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix! I'll merge this later when the CI is done.

I have updated the PR with a more sustainable fix that returns the minimum state early. Otherwise, there other undefined floating point behavior down the line.

@guitargeek guitargeek assigned guitargeek and unassigned lmoneta Sep 27, 2023
This avoids the problems when running simplex with zero parameters
reported in root-project#6775.
@guitargeek
Copy link
Contributor

@phsft-bot build

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

@guitargeek guitargeek merged commit 6e556ce into root-project:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] [minuit] FPE/crash in Minuit2

4 participants