Skip to content

[doxy] precompile libs script #10004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2022
Merged

[doxy] precompile libs script #10004

merged 2 commits into from
Mar 22, 2022

Conversation

ferdymercury
Copy link
Collaborator

This Pull request:

Changes or fixes:

Precompiles C++ script to potentially speedup (slightly) documentation building

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ferdymercury ferdymercury requested a review from couet as a code owner March 1, 2022 22:23
@phsft-bot
Copy link

Can one of the admins verify this patch?

@ferdymercury
Copy link
Collaborator Author

@couet does this change work on your end?

@couet
Copy link
Member

couet commented Mar 22, 2022

Yes it works. I am not sure if it really speed up the execution a lot. But why not doing it this may. Have you done some speed up measurement ? Note we also have more .C macros: MakeRCanvasJS.C, MakeTCanvasJS.C and makeimage.C

Copy link
Member

@couet couet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. I merge. Potentially should it be done also for the other .C macros ?

@couet couet merged commit ce6292c into root-project:master Mar 22, 2022
@ferdymercury ferdymercury deleted the patch-4 branch March 22, 2022 09:39
@ferdymercury
Copy link
Collaborator Author

Yes it works. I am not sure if it really speed up the execution a lot. But why not doing it this may. Have you done some speed up measurement ? Note we also have more .C macros: MakeRCanvasJS.C, MakeTCanvasJS.C and makeimage.C

Sorry, I didn't see this message. I did not do speed-up measurements.

Concerning makeimage and the others, I tried once and saw some problems when enabling multihreading, not sure why, so I did not look into it further.

Neel-Shah-29 pushed a commit to Neel-Shah-29/root-1 that referenced this pull request Apr 6, 2022
* precompile

* add missing headers
@ferdymercury
Copy link
Collaborator Author

Related: d8d71f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants