Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link in HS3 printout #15370

Closed
1 task done
mmikhasenko opened this issue Apr 28, 2024 · 5 comments · Fixed by #15373
Closed
1 task done

Broken link in HS3 printout #15370

mmikhasenko opened this issue Apr 28, 2024 · 5 comments · Fixed by #15373

Comments

@mmikhasenko
Copy link

mmikhasenko commented Apr 28, 2024

Check duplicate issues.

  • Checked for duplicates

Description

A minor note on warning message from HS3 suggest non-existing page,
https://github.com/root-project/root/blob/master/roofit/hs3/README.md

Full message

unable to export class 'RooBreitWigner' - no export keys available!
there are several possible reasons for this:
 1. RooBreitWigner is a custom class that you or some package you are using added.
 2. RooBreitWigner is a ROOT class that nobody ever bothered to write a serialization definition for.
 3. something is wrong with your setup, e.g. you might have called RooFit::JSONIO::clearExportKeys() and/or never successfully read a file defining these keys with RooFit::JSONIO::loadExportKeys(filename)
either way, please make sure that:
 3: you are reading a file with export keys - call RooFit::JSONIO::printExportKeys() to see what is available
 2 & 1: you might need to write a serialization definition yourself. check https://github.com/root-project/root/blob/master/roofit/hs3/README.md to see how to do this!
(int) 0

Reproducer

  1. Use the latest root,
    source /cvmfs/sft.cern.ch/lcg/views/dev3/latest/x86_64-el9-gcc13-opt/setup.sh

  2. run a script, root -l -b -q export_pdf.cxx++

#include "RooRealVar.h"
#include "RooBreitWigner.h"
#include "RooWorkspace.h"
#include "RooFitHS3/RooJSONFactoryWSTool.h"

int export_pdf()
{
    RooRealVar x("x", "x", -10, 10);
    RooRealVar mean("mean", "mean of gaussian", 1, -10, 10);
    RooRealVar gamma("gamma", "width of bw", 1, 0.1, 10);
    RooBreitWigner bw("bw", "non-rel bw", x, mean, gamma);

    RooWorkspace w("ws");
    w.import(bw);

    RooJSONFactoryWSTool tool(w);
    tool.exportJSON("standard_pdf.json");
    return 0;
}

ROOT version

root --version
ROOT Version: 6.33/01
Built for linuxx8664gcc on Apr 26 2024, 23:06:35
From heads/master@v6-31-01-1819-gb5ad658677

Installation method

LCG

Operating system

Linux

Additional context

No response

Copy link

Hi @guitargeek,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely,
🤖

guitargeek pushed a commit that referenced this issue Apr 30, 2024
Copy link

github-actions bot commented May 1, 2024

Hi @guitargeek,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely,
🤖

3 similar comments
Copy link

github-actions bot commented May 2, 2024

Hi @guitargeek,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely,
🤖

Copy link

github-actions bot commented May 3, 2024

Hi @guitargeek,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely,
🤖

Copy link

github-actions bot commented May 6, 2024

Hi @guitargeek,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely,
🤖

PPaye pushed a commit to PPaye/root that referenced this issue Jun 3, 2024
silverweed pushed a commit to silverweed/root that referenced this issue Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants