6.26.14 tag fails to build

[JGCarroll]

Check duplicate issues.

• Checked for duplicates

Description

The 6.26.14 tag fails to build with the following errors emitted by GCC:

/root/parts/root/src/rootx/src/rootcoreteam.h:12:32: error: stray ‘\’ in program
   12 | const char *gROOTCoreTeam[] = {\n   "Rene Brun",
      |                                ^
/root/parts/root/src/rootx/src/rootcoreteam.h:31:29: error: stray ‘\’ in program
   31 |    "Enric Tejedor Saavedra",\n   0\n };
      |                             ^
/root/parts/root/src/rootx/src/rootcoreteam.h:31:35: error: stray ‘\’ in program
   31 |    "Enric Tejedor Saavedra",\n   0\n };

/root/parts/root/src/rootx/src/rootcoreteam.h:12:33: error: ‘n’ was not declared in this scope
12 | const char *gROOTCoreTeam[] = {\n   "Rene Brun",
   |                                 ^
/root/parts/root/src/rootx/src/rootcoreteam.h:12:37: error: expected ‘}’ before string constant
12 | const char *gROOTCoreTeam[] = {\n   "Rene Brun",
   |                               ~     ^~~~~~~~~~~
/root/parts/root/src/rootx/src/rootcoreteam.h:34:1: error: expected declaration before ‘}’ token
34 | } // namespace ROOT
   | ^

Reproducer

Checkout 6-26-14 and attempt to build from source.

ROOT version

6.26.14

Installation method

Source

Operating system

Ubuntu 20.04

Additional context

Failing in Snap build environment, which could be related but the errors look like general syntax errors that would effect most build environments.

[guitargeek]

Hi! Is this not fixed by the following commit?
41212a8

[dpiparo]

Hello @MrCarroll ,

I am sorry you experienced this issue. Are you sure you are using the v6-26-14 tag and not the v6-26-12 tag? The latter has indeed a problem. Our automated release procedure is steered by scripts. One of those scripts was not correctly taking into account a particular case and ended up modifying a C++ file but introduced text which resulted in invalid C++ code - this is the error you reported.

Could you please doublecheck that you are using v6-26-14?

Thanks a lot in advance.

[JGCarroll]

Hi both,

Somewhat embarassingly, Danilo is correct. I've been occupied heavily with work lately and with this being my third build of ROOT today didn't notice the exact rookie mistake that's been presumed; I'd accidentally put into my build script the hash for 6.26.12 and not 6.26.14 which I intended (and more frustratingly, I'd then added a comment saying #6.26.14).

Please disregard this issue. It's correct in the context of 6.26.12 but then the problem was fixed already and 6.26.12 was only ever the latest release for about a day.

Thanks for your assistance both, and my apologies for the misfire!

[dpiparo]

@MrCarroll do not worry. These things happen, especially when one is under heavy load at work. Never hesitate to report issues as you encounter them, feedback is very important for us!

[github-actions]

Hi @guitargeek, @dpiparo,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely,
🤖