Fix crash when dumping an un-evaluated cling::Value #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsupial
force-pushed
the
PR/4
branch
2 times, most recently
from
348f829 to
10e40ba
Compare
|
The value printing has changed too much. While I'd love to incorporate these changes they don't apply as is, and porting them takes more effort than I can invest here. Thus closing - but I'd be happy if anyone can re-implement these changes for the current cling! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following code which will currently crash:
The first commit while not totally related was for conflict resolution against 27aea4b and reports the error through clang's diagnostics.