Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply PECS where it is missing #16

Closed
1 task done
roookeee opened this issue Jun 13, 2019 · 3 comments
Closed
1 task done

Apply PECS where it is missing #16

roookeee opened this issue Jun 13, 2019 · 3 comments
Assignees
@roookeee
Labels
bug Something isn't working enhancement New feature or request resolved in develop semver-patch
Milestone
1.2.0

Comments

@roookeee
Copy link
Owner

roookeee commented Jun 13, 2019 •
edited
Loading

As a library datus should follow PECS. Most parts of datus are already PECS compliant but some functions that were added just before releasing 1.0 don't comply yet (or they have just slipped my attention).

I will categorize this issue as semver-minor because applying PECS is backwards compatible and not being able to use functions/predicates/etc. that would work with PECS is more of a bug than a new feature.

  • Mapper interface
@roookeee roookeee self-assigned this Jun 13, 2019
@roookeee roookeee added this to the 1.2.0 milestone Jun 13, 2019
@roookeee roookeee added bug Something isn't working enhancement New feature or request labels Jun 13, 2019
@roookeee roookeee mentioned this issue Jun 13, 2019
Closed
@roookeee
Copy link
Owner Author

Done with the Mapper interface in branch issue-16

@roookeee
Copy link
Owner Author

I will exclude the Datus helper class as it would be pretty bizarre to run in any PECS related issues there

@roookeee
Copy link
Owner Author

I have triple checked every class now, let's hope I found everything - will merge this now

roookeee added a commit that referenced this issue Jun 24, 2019
@roookeee
ISSUE-16(#16): Apply PECS where it is missing
8fa93b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roookeee roookeee

Labels
bug Something isn't working enhancement New feature or request resolved in develop semver-patch
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
1 participant
@roookeee