-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add core/average.py/average_shape to ops/average.py #312
Conversation
Welcome, new contributor! It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the
Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨ |
Pull Request Test Coverage Report for Build 7277865257
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This is unrelated to this PR, but I had some trouble with the installation of the dependencies. toolz and xarray required an upgrade after the conda env update.
@huard The reason for needing to perform an update after creating the environment is because more recent versions of xarray don't support some The workaround is to not install the latest xarray when using xESMF (not a great solution, but we weren't sure how else to proceed). |
Congrats @charlesgauthier-udm ! I'll stage a new release, given that we now have some new functions from both you and Martin (@sol1105). |
Pull Request Checklist:
AUTHORS.md
What kind of change does this PR introduce?:
This PR exposes average_Shape from clisops/core to clisops/ops
Does this PR introduce a breaking change?:
Not to my knowledge
Other information:
As mentioned above, this PR is part of the work related to this issue outside of clisops