Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core/average.py/average_shape to ops/average.py #312

Merged
merged 15 commits into from
Dec 20, 2023

Conversation

charlesgauthier-udm
Copy link
Contributor

Pull Request Checklist:

  • [~] This PR addresses an already opened issue (for bug fixes / features)
    • This PR is related to this issue outside of clisops
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • The new ops/average_shape is documented based on the other functions in ops/average.py, Please let me know if anything else needs to be added.
  • HISTORY.rst has been updated (with summary of main changes)
  • I have added my relevant user information to AUTHORS.md

What kind of change does this PR introduce?:

This PR exposes average_Shape from clisops/core to clisops/ops

Does this PR introduce a breaking change?:

Not to my knowledge

Other information:

As mentioned above, this PR is part of the work related to this issue outside of clisops

Copy link

github-actions bot commented Dec 18, 2023

Welcome, new contributor!

It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the AUTHORS.rst:

  • The relevant author information has been added to AUTHORS.rst

Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨

@coveralls
Copy link

coveralls commented Dec 18, 2023

Pull Request Test Coverage Report for Build 7277865257

  • 10 of 23 (43.48%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on savg at 72.348%

Changes Missing Coverage Covered Lines Changed/Added Lines %
clisops/core/average.py 1 2 50.0%
clisops/ops/average.py 7 19 36.84%
Totals Coverage Status
Change from base Build 7277603029: 72.3%
Covered Lines: 1732
Relevant Lines: 2394

💛 - Coveralls

Copy link
Contributor

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

This is unrelated to this PR, but I had some trouble with the installation of the dependencies. toolz and xarray required an upgrade after the conda env update.

clisops/core/average.py Outdated Show resolved Hide resolved
clisops/ops/average.py Outdated Show resolved Hide resolved
@Zeitsperre
Copy link
Collaborator

@huard The reason for needing to perform an update after creating the environment is because more recent versions of xarray don't support some cftime objects (see: pydata/xarray#7794).

The workaround is to not install the latest xarray when using xESMF (not a great solution, but we weren't sure how else to proceed).

HISTORY.rst Outdated Show resolved Hide resolved
@Zeitsperre Zeitsperre merged commit e0486ba into roocs:master Dec 20, 2023
11 checks passed
@Zeitsperre
Copy link
Collaborator

Congrats @charlesgauthier-udm !

I'll stage a new release, given that we now have some new functions from both you and Martin (@sol1105).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants