Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin xarray for xesmf-based regridding #310

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Pin xarray for xesmf-based regridding #310

merged 7 commits into from
Nov 30, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Nov 29, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes issue #xyz
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
  • I have added my relevant user information to AUTHORS.md

What kind of change does this PR introduce?:

  • Emits a warning whenever attempting to use the regridding tools with newer xarray versions
  • Fixes an import issue in ops
  • Adds a pinned version of xarray to the extras recipe

Does this PR introduce a breaking change?:

No.

Other information:

@Zeitsperre Zeitsperre added the dependencies Pull requests that update a dependency file label Nov 29, 2023
@Zeitsperre Zeitsperre self-assigned this Nov 29, 2023
@coveralls
Copy link

coveralls commented Nov 29, 2023

Pull Request Test Coverage Report for Build 7039086852

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on open-xarray-pin at 72.112%

Totals Coverage Status
Change from base Build 6981551428: 72.1%
Covered Lines: 1704
Relevant Lines: 2363

💛 - Coveralls

@Zeitsperre
Copy link
Collaborator Author

@cehbrecht

This will tie-in with the changes on conda-forge to give us a workaround for now. The user should be made aware of these changes.

@Zeitsperre Zeitsperre merged commit 08555fe into master Nov 30, 2023
11 checks passed
@Zeitsperre Zeitsperre deleted the open-xarray-pin branch November 30, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants