Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid warnings in Ruby 3.1 when finalizer is called twice [fix #585] #586

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Avoid warnings in Ruby 3.1 when finalizer is called twice [fix #585] #586

merged 1 commit into from
Jun 29, 2023

Conversation

owst
Copy link
Contributor

@owst owst commented Feb 16, 2023

Fixes #585

@owst owst force-pushed the avoid_ruby_31_finalizer_warnings_when_called_twice branch from 7a5a7e7 to f14a1e2 Compare February 16, 2023 17:09
@owst
Copy link
Contributor Author

owst commented Mar 30, 2023

@patrickkulling any chance you could take a look at this? It's causing quite a lot of noise in our development environments

@patrickkulling
Copy link
Contributor

@kakubin can you have a look at this please? I am currently on vacation for a while

@owst
Copy link
Contributor Author

owst commented Apr 3, 2023

@kakubin - have you had a chance to look at this PR? Hopefully it's uncontroversial!

kakubin
kakubin approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@kakubin kakubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you
Its looks good

@owst
Copy link
Contributor Author

owst commented Apr 18, 2023

Thanks @kakubin! Do you know when this can be merged (and released)?

@owst
Copy link
Contributor Author

owst commented May 18, 2023

Ping @kakubin or @patrickkulling - it would be great to get this merged and released if we can!

@owst
Copy link
Contributor Author

owst commented Jun 12, 2023

Another ping at @kakubin and @patrickkulling - is there a plan to get this merged (and released)?

@kakubin
Copy link
Contributor

kakubin commented Jun 13, 2023

@patrickkulling
I don't have the authority to merge, so I would like to ask you

@patrickkulling patrickkulling merged commit 00850f1 into roo-rb:master Jun 29, 2023
@patrickkulling
Copy link
Contributor

@owst sorry for the long delay. it's merged but I am lacking rights to create a patch release.

@ermolaev
Copy link

@simonoff you can push new version with this patch to rubygems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakubin kakubin kakubin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tempfile cleanup causes warning on Ruby 3.1 when using Spring (or other forking preloader)
4 participants
@owst @patrickkulling @kakubin @ermolaev