Skip extract_hyperlinks if not required #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revisiting roo-rb#436 . This Patch uses relationships data to determine if a sheet includes hyperlinks or not. As extract_hyperlinks loads the whole document in memory it is quite problematic for each_row_streaming. This patch tries to skip extract_hyperlinks when not required.
chopraanmol1
force-pushed
the
skip_extract_hyperlinks_if_not_required
branch
from
6170cf9
to
4b1e6f0
Compare
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 6, 2019
## [2.8.2] 2019-02-01 ### Changed/Added - Support range cell for Excelx's links [490](roo-rb/roo#490) - Skip `extract_hyperlinks` if not required [488](roo-rb/roo#488) ### Fixed - Fixed error for invalid link [492](roo-rb/roo#492) ## [2.8.1] 2019-01-21 ### Fixed - Fixed error if excelx's cell have empty children [487](roo-rb/roo#487)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisiting #436
This Patch uses relationships data to determine if a sheet includes hyperlink or not.
As extract_hyperlinks loads the whole document in memory it is quite problematic for each_row_streaming. This patch tries to skip extract_hyperlinks when not required.