Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support of URL for CSV #462

Merged

Commits on Oct 5, 2018

  1. Restore support of URL for CSV

    ### Benchmark
    
    ```
    file_name = 'test/files/Bibelbund.csv'
    
    MemoryProfiler.report{ Roo::Spreadsheet.open(file_name).tap{|x|(2..x.last_row).each{|i| x.row(i)}} }
    puts Benchmark.measure{ Roo::Spreadsheet.open(file_name).tap{|x|(2..x.last_row).each{|i| x.row(i)}} }
    ```
    
    Master
    ```
    Total allocated: 39705265 bytes (561479 objects)
    Total retained:  768 bytes (4 objects)
    
      0.300000   0.000000   0.300000 (  0.304877)
    ```
    
    Modified:
    ```
    Total allocated: 16952085 bytes (234487 objects)
    Total retained:  768 bytes (4 objects)
    
      0.190000   0.000000   0.190000 (  0.181199)
    ```
    chopraanmol1 committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    e29ffe7 View commit details
    Browse the repository at this point in the history