Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image parser module #317

Closed
wants to merge 7 commits into from
Closed

Add image parser module #317

wants to merge 7 commits into from

Conversation

Mashychev
Copy link

No description provided.

@coveralls
Copy link

coveralls commented May 19, 2016

Coverage Status

Coverage decreased (-1.09%) to 93.261% when pulling 3288043 on Mashychev:develop into 211f89b on roo-rb:master.

@coveralls
Copy link

coveralls commented May 19, 2016

Coverage Status

Coverage decreased (-1.1%) to 93.217% when pulling 8b8810a on Mashychev:develop into 211f89b on roo-rb:master.

@coveralls
Copy link

coveralls commented May 19, 2016

Coverage Status

Coverage decreased (-0.05%) to 94.298% when pulling a420130 on Mashychev:develop into 211f89b on roo-rb:master.

@coveralls
Copy link

coveralls commented May 19, 2016

Coverage Status

Coverage increased (+0.09%) to 94.442% when pulling 28809ff on Mashychev:develop into 211f89b on roo-rb:master.

@simonoff
Copy link
Member

simonoff commented May 20, 2016

We need to have this functionality inside ::Roo::Excelx::Sheet where it best place. So developer can through some call images take all images in sheet.

@coveralls
Copy link

coveralls commented May 26, 2016

Coverage Status

Coverage increased (+0.04%) to 94.389% when pulling e74f802 on Mashychev:develop into 211f89b on roo-rb:master.

@coveralls
Copy link

coveralls commented May 30, 2016

Coverage Status

Coverage increased (+0.06%) to 94.407% when pulling 59d8d98 on Mashychev:develop into 211f89b on roo-rb:master.

@simonoff
Copy link
Member

Better but still not efficient.
You read zip file two times, which is not good.
You can look on process_zipfile_entries method. Where zip file is processed. So you can add extracting images there.

@simonoff
Copy link
Member

@Mashychev may be you can found a time and finish this PR?

@stevendaniels
Copy link
Contributor

Replaced with #414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants