move ERROR_VALUES from Excelx::Cell::Number ~> Excelx
#280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intialize ERROR_VALUES as `Set` for performace impact added test cases
|
Thanks for this. Unfortunately, I'm closing this as unnecessary. I appreciate the help, though. |
|
Okay, but I still believe that this should be added in the codebase. |
|
On second thought, you're not wrong. Thanks for the PR. |
stevendaniels
added a commit
that referenced
this pull request
Dec 18, 2015
move `ERROR_VALUES` from Excelx::Cell::Number ~> Excelx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stevendaniels: As per our discussion on commit, I created this PR.