Excelx hyperlink r:id fix + to_csv fix for :link types = no more failing tests #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmitting a previous pull request. This one is off of a branch in my repo so I can update my master.
I was about to start working on some enhancements, but found that the test suite wasn't passing at least on my system (Mac - Mavericks). I made some fixes and got "bundle exec rake test" and "bundle exec rspec" to both pass without failures. One "error" remains in test:
test_bug_pfand_from_windows_phone_xlsx(TestRoo):
Encoding::CompatibilityError: incompatible encoding regexp match (US-ASCII regexp with UTF-16 string) for excelx
I left that one as-is.
Part of this pull request reverts what was done in #123 to an earlier commit within that same pull request.
Where the xpath was changed to hyperlink[id] from just hyperlink based on a dialogue with Empact. My test suite failed on that -- perhaps due to a Nokogiri platform issue?? Because the Excelx file had the id field with a namespace prefix "r:" the normal [id] selector was not working. I figure that most entries in the Excelx references file that are "hyperlink" elements would have an id, so I'd suggest going back to being without [id] for safety. I added back the nil check that rui-castro had done initially.
Thanks for considering, and thanks so much for this great gem!