Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excelx hyperlink r:id fix + to_csv fix for :link types = no more failing tests #135

Closed
wants to merge 6 commits into from

Conversation

thefooj
Copy link
Contributor

@thefooj thefooj commented Jun 5, 2014

Resubmitting a previous pull request. This one is off of a branch in my repo so I can update my master.

I was about to start working on some enhancements, but found that the test suite wasn't passing at least on my system (Mac - Mavericks). I made some fixes and got "bundle exec rake test" and "bundle exec rspec" to both pass without failures. One "error" remains in test:

  1. Error:
    test_bug_pfand_from_windows_phone_xlsx(TestRoo):
    Encoding::CompatibilityError: incompatible encoding regexp match (US-ASCII regexp with UTF-16 string) for excelx

I left that one as-is.

Part of this pull request reverts what was done in #123 to an earlier commit within that same pull request.

Where the xpath was changed to hyperlink[id] from just hyperlink based on a dialogue with Empact. My test suite failed on that -- perhaps due to a Nokogiri platform issue?? Because the Excelx file had the id field with a namespace prefix "r:" the normal [id] selector was not working. I figure that most entries in the Excelx references file that are "hyperlink" elements would have an id, so I'd suggest going back to being without [id] for safety. I added back the nil check that rui-castro had done initially.

Thanks for considering, and thanks so much for this great gem!

@thefooj
Copy link
Contributor Author

thefooj commented Jun 5, 2014

Added a further commit, refactoring zipfile processing. Is there any reason the zipfile was being opened twice with ultimately the same filename?

thefooj@c7dd6f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants