Fix parsing of .xlsx files exported from Numbers #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numbers 3.1 can export .xlsx files, but the feature has some
incensistencies and bugs.
This commit fixes an inconsistency where the first sheet doesn't have
have an index in the XML filename ("sheet.xml"), whereas such sheet
would be named "sheet1.xml" by Excel.
This fix is inspired by a solution provided in roo-rb#110.
Empact
added a commit
that referenced
this pull request
Mar 27, 2014
Fix parsing of .xlsx files exported from Numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numbers 3.1 can export .xlsx files, but the feature has some incensistencies and bugs.
This commit handles an inconsistency where the first sheet doesn't have have an index in the XML filename ("sheet.xml"), whereas such sheet would be named "sheet1.xml" by Excel. Trying to read such files would raise the following exception:
This fix is inspired by a solution provided in #110 by @janis-grigaluns. Kudos!