Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated blob field return type #31

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Updated blob field return type #31

merged 2 commits into from
Jan 28, 2025

Conversation

NuroDev
Copy link
Member

@NuroDev NuroDev commented Jan 28, 2025

This PR fixes a small bug with the FieldsToTypes type where the blob field was being mapped to a Blob type when we actually return JSON stored as a StoredObject.

@NuroDev NuroDev requested review from leo and colodenn January 28, 2025 11:13
@NuroDev NuroDev self-assigned this Jan 28, 2025
@NuroDev NuroDev enabled auto-merge (squash) January 28, 2025 11:13
Copy link

github-actions bot commented Jan 28, 2025

Released an experimental package:

bun add @ronin/syntax@fix-blob-field-type-experimental-79

This package will be removed after the pull request has been merged.

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/schema/model.ts 100.00% <ø> (ø)

@NuroDev NuroDev merged commit a1175f4 into main Jan 28, 2025
3 checks passed
@NuroDev NuroDev deleted the fix/blob-field-type branch January 28, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants