Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix HTTPX async event hook #129

Merged
merged 7 commits into from
Apr 4, 2022
Merged

Conversation

roniemartinez
Copy link
Owner

Traceback (most recent call last):
...
    await hook(request)
TypeError: object NoneType can't be used in 'await' expression

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #129 (362ace8) into master (9f0adb5) will decrease coverage by 0.08%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   97.28%   97.19%   -0.09%     
==========================================
  Files          14       14              
  Lines        1104     1106       +2     
==========================================
+ Hits         1074     1075       +1     
- Misses         30       31       +1     
Impacted Files Coverage Δ
dude/optional/beautifulsoup_scraper.py 100.00% <ø> (ø)
dude/optional/lxml_scraper.py 100.00% <ø> (ø)
dude/optional/parsel_scraper.py 100.00% <ø> (ø)
dude/optional/utils.py 98.03% <50.00%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0adb5...362ace8. Read the comment docs.

@roniemartinez roniemartinez force-pushed the fix-async-event-hook branch from 2add0f4 to 76f08af Compare April 4, 2022 19:45
@roniemartinez roniemartinez merged commit 3c5ce86 into master Apr 4, 2022
@roniemartinez roniemartinez deleted the fix-async-event-hook branch April 4, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants