Ensure ./tmp dir exists #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@rondale-sc - Should be ready for release when you have a chance. |
| } | ||
| }, | ||
| tmpDir: function() { | ||
| path.join(process.cwd(), 'tmp'); |
There was a problem hiding this comment.
Shouldn't there be return here?
There was a problem hiding this comment.
Yes, sure...I messed it up when doing rebase for the PR...
There was a problem hiding this comment.
Sorry, my bad, should have tested the final version of PR 😳
There was a problem hiding this comment.
@jesenko - Mind submitting a fixing PR?
There was a problem hiding this comment.
Just did, PR #9
On 25 Jan 2015, at 18:32, Robert Jackson notifications@github.com wrote:
In index.js:
}},
- lockfilePath: function() {
- return path.join(process.cwd(), 'tmp', 'build.lock');
- ensureTmp: function() {
- var dir = this.tmpDir();
- if (!fs.existsSync(dir)){
fs.mkdirSync(dir);- }
- },
- tmpDir: function() {
- path.join(process.cwd(), 'tmp');
@jesenko - Mind submitting a fixing PR?—
Reply to this email directly or view it on GitHub.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building of ember app fails if
./tmpfolder within ember-cli root does not exist asbuild.lockfile cannot be created.Normally
./tmpfolder is created in ember-cli build process; if ember-cli-rails-addon is added prior to first successful build,./tmpfolder does not yet exist.This PR ensures that tmp folder exists. It also fixes some syntax errors related to scoping of variables introduced in previous commit.