No longer listen for buildError callback
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to [tricknotes/ember-cli-rails#318][#318]. The `ember-cli-rails` gem redirects the `ember build --watch` process' `STDERR` to the same file the addon previously wrote two. These two processes would contend over writing to the file, and flip-flop, clobbering the others' output. To correct this, we'll defer error logging to the gem (and ultimately, `ember-cli`'s writing correctly to `STDERR`). [#318]: tricknotes/ember-cli-rails#318
seanpdoyle
force-pushed
the
sd-build-error
branch
from
b45fcfd
to
69e890e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to thoughtbot/ember-cli-rails#318.
The
ember-cli-railsgem redirects theember build --watchprocess'STDERRto the same file the addon previously wrote two.These two processes would contend over writing to the file, and
flip-flop, clobbering the others' output.
To correct this, we'll defer error logging to the gem (and ultimately,
ember-cli's writing correctly toSTDERR).