Insee : Return data instead of true. #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soullivaneuh
suggested changes
Nov 2, 2017
| @@ -110,6 +110,6 @@ public static function validate($numero) | |||
| return false; | |||
| } | |||
|
|
|||
| return true; | |||
| return $return; | |||
There was a problem hiding this comment.
👎 for several reasons:
- It's currently a BC break.
- IMHO return mixed type when we are able to avoid it is a bad practice, especially since the possibility of strict typing.
We may pass an array as reference instead to fill the data. And this array must be optional.
The another solution would be to have a separate method likegetInfo(string $insee)for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the data array instead of true, as it should be (@return doc).