Skip to content

Add support for type and schema attributes#596

Merged
juntyr merged 7 commits intomasterfrom
attrs
Feb 1, 2026
Merged

Add support for type and schema attributes#596
juntyr merged 7 commits intomasterfrom
attrs

Conversation

@torkleyy
Copy link
Member

@torkleyy torkleyy commented Jan 30, 2026

Now we are compatible with tooling like https://github.com/ron-rs/ron2

  • I've included my change in CHANGELOG.md

@juntyr
Copy link
Member

juntyr commented Jan 30, 2026

Thanks @torkleyy! The changes look good to me. Could you also update the version pins in the 1.64 CI so that CI runs and passes?

@torkleyy
Copy link
Member Author

I'm trying :D I wonder if we should commit some sort of lockfile for 1.64 specifically...

@juntyr
Copy link
Member

juntyr commented Jan 30, 2026

I'm trying :D I wonder if we should commit some sort of lockfile for 1.64 specifically...

That might be an idea ... we could also bump the MSRV of course but at the same time who knows if somebody still needs RON with an old Rust version

cargo update -Z minimal-versions
cargo update -Z direct-minimal-versions

did not make sense; one command overrides the other. When combining both, we actually get the intended effect - but since some crates specify an incorrect minimum version, we need to do selective upgrades instead of downgrades.
@juntyr
Copy link
Member

juntyr commented Feb 1, 2026

That's a clever way to do it too :D

Do we still need the explicit bound patching then?

Once you're happy with the PR, please ping me and I'll re-review and merge it

@torkleyy
Copy link
Member Author

torkleyy commented Feb 1, 2026

Thanks :D Yes, we do need explicit upgrades, since some dependencies have a minimum version specified that is broken. So now instead of downgrading for 1.64.0 (which we did previously, since the cargo update commands did not what was intended), we now upgrade to the minimum non broken version for every job using Cargo.min.lock.

@torkleyy
Copy link
Member Author

torkleyy commented Feb 1, 2026

I consider it done, feel free to merge whenever

Copy link
Member

@juntyr juntyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@juntyr juntyr merged commit f159742 into master Feb 1, 2026
10 checks passed
@juntyr juntyr deleted the attrs branch February 1, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants