Conversation
|
Thanks @torkleyy! The changes look good to me. Could you also update the version pins in the 1.64 CI so that CI runs and passes? |
|
I'm trying :D I wonder if we should commit some sort of lockfile for 1.64 specifically... |
That might be an idea ... we could also bump the MSRV of course but at the same time who knows if somebody still needs RON with an old Rust version |
cargo update -Z minimal-versions cargo update -Z direct-minimal-versions did not make sense; one command overrides the other. When combining both, we actually get the intended effect - but since some crates specify an incorrect minimum version, we need to do selective upgrades instead of downgrades.
|
That's a clever way to do it too :D Do we still need the explicit bound patching then? Once you're happy with the PR, please ping me and I'll re-review and merge it |
|
Thanks :D Yes, we do need explicit upgrades, since some dependencies have a minimum version specified that is broken. So now instead of downgrading for 1.64.0 (which we did previously, since the |
|
I consider it done, feel free to merge whenever |
Now we are compatible with tooling like https://github.com/ron-rs/ron2
CHANGELOG.md