Add Serializer::into_inner method to extract the writer #588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is my first pull request :)
I will try to do my best, don’t hesitate to give me any tips on how I can improve.
Description
This add an
into_inner()method toron::ser::Serializer, allowing users to get back the inner writer.The name and documentation is the same as the
serde_json::Serializer::into_inner().(it also have the MIT OR Apache-2.0 licence)
Motivation
A typical use case of ron looks like:
However, wrapping this operation into a trait + a
'staticstructure is impossible without aninto_inner():The only way is to also store the buf in the same structure, but that can't be express in rust to my knowledge:
So I don't think storing a ron serializer to progressively serialize somethings, them getting back the serialized string in a lifetimeless / 'static structure is not possible without an
into_inner()method.(My use case is to wrap a ron serializer into another serializer)