Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Map::retain method #460

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

marcospb19
Copy link
Contributor

  • I've included my change in CHANGELOG.md

src/value/mod.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.37 ⚠️

Comparison is base (8fa9995) 85.65% compared to head (b4db797) 85.29%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   85.65%   85.29%   -0.37%     
==========================================
  Files          61       61              
  Lines        7760     7793      +33     
==========================================
  Hits         6647     6647              
- Misses       1113     1146      +33     
Impacted Files Coverage Δ
src/value/mod.rs 46.42% <0.00%> (-3.96%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@juntyr juntyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the suggested changes applied.

Thank you @marcospb19 for your contribution!

@marcospb19
Copy link
Contributor Author

Force-pushed accordingly, thanks for the great review :D .

Copy link
Member

@juntyr juntyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juntyr juntyr merged commit 82536cf into ron-rs:master Jun 28, 2023
@marcospb19 marcospb19 deleted the add-map-retain-method branch June 28, 2023 07:40
juntyr pushed a commit to juntyr/ron that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants