-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard u128
and i128
behind optional integer128
feature
#351
Conversation
@torkleyy @kvark @caiiiycuk I've started the implementation to add an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I believe the direction is sound
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
u128
and i128
behind on-by-default integer128
featureu128
and i128
behind optional integer128
feature
This PR adds an optional
integer128
feature that guards the usage ofi128
andu128
. Therefore, any library usingserde
with either of these types should now enable the feature. This PR is heavily inspired by #304.CHANGELOG.md