Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserializer rework #27

Merged
merged 4 commits into from
Aug 2, 2017
Merged

Deserializer rework #27

merged 4 commits into from
Aug 2, 2017

Conversation

torkleyy
Copy link
Contributor

@torkleyy torkleyy commented Aug 1, 2017

This PR gets rid of the parser (POM). The goal is to make deserialization faster and avoid unnecessary dependencies. It seems that RON is simple enough to be parsed without some framework; these libraries tend to have Box<Fn> and Vec all over the place.

@kvark
Copy link
Collaborator

kvark commented Aug 1, 2017

r=me when ready

@kvark
Copy link
Collaborator

kvark commented Aug 2, 2017

Awesome work, :shipit: !
bors r+

@bors
Copy link
Contributor

bors bot commented Aug 2, 2017

🔒 Permission denied

Existing reviewers: click here to make kvark a reviewer

@kvark
Copy link
Collaborator

kvark commented Aug 2, 2017 via email

bors bot added a commit that referenced this pull request Aug 2, 2017
27: Deserializer rework r=kvark

This PR gets rid of the parser (POM). The goal is to make deserialization faster and avoid unnecessary dependencies. It seems that RON is simple enough to be parsed without some framework; these libraries tend to have `Box<Fn>` and `Vec` all over the place.
@bors
Copy link
Contributor

bors bot commented Aug 2, 2017

Build succeeded

@bors bors bot merged commit 6267b27 into ron-rs:master Aug 2, 2017
@torkleyy torkleyy deleted the rework branch August 2, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants