Fix parsing of borrowed strings #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of `deserialize_str` would incorrectly call `Visitor::visit_str` when it should have called `Visitor::visit_borrowed_str`. As per https://serde.rs/lifetimes.html#transient-borrowed-and-owned-data, `visit_borrowed_str` should be called when the lifetime of the deserialized string is that of the input. This should not be a breaking change, because it only adds more guarantees to the lifetime of the deserialized string. The default implementation of `Visitor::visit_borrowed_str` forwards to `visit_str`, meaning that this change only enables more flexibility.
kvark
approved these changes
May 8, 2020
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
deserialize_strwould incorrectly callVisitor::visit_strwhen it should have calledVisitor::visit_borrowed_str. As per https://serde.rs/lifetimes.html#transient-borrowed-and-owned-data,visit_borrowed_strshould be called when the lifetime of the deserialized string is that of the input.This should not be a breaking change, because it only extends the lifetime of the deserialized string. The default implementation of
Visitor::visit_borrowed_strforwards tovisit_str, meaning that this commit only enables more flexibility.I added a test in
tests/borrowed_str.rswhich demonstrates this behavior. Prior to this change, the test would fail.