Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reexport Value at root #120

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Reexport Value at root #120

merged 1 commit into from
Aug 1, 2018

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Jul 30, 2018

Hi! As a client of ron, I'd love to be able to use ron::Value :0)

@kvark
Copy link
Collaborator

kvark commented Jul 30, 2018

Thank you!
I think we should hide value module then in the next breaking change.
bors r+

@torkleyy
Copy link
Contributor

Thanks @matklad! Seems bors is stuck?

@torkleyy
Copy link
Contributor

bors r-

@torkleyy
Copy link
Contributor

Just took a look at the log, it crashed: https://app.bors.tech/repositories/865/log

torkleyy
torkleyy approved these changes Aug 1, 2018
View reviewed changes
Copy link
Contributor

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's do it manually.

@torkleyy torkleyy merged commit cfb92c4 into ron-rs:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkleyy torkleyy torkleyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matklad @kvark @torkleyy