misc: Initial addition of IGDB typehints #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The short-term goal is to completely typehint the IGDB API responses. This first change adds the base structures and enums RomM currently uses. The `ExpandableField` type will allow us to model the expansion mechanism the IGDB API provides, where a field can include either an ID, or the full nested structure.
adamantike
force-pushed
the
misc/initial-igdb-typehints
branch
from
9b88af8
to
4bb5cb5
Compare
|
Great idea! This will help to make the API interaction much robust |
zurdi15
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The short-term goal is to completely typehint the IGDB API responses. This first change adds the base structures and enums RomM currently uses.
The
ExpandableFieldtype will allow us to model the expansion mechanism the IGDB API provides, where a field can include either an ID, or the full nested structure.